Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use POTel use_scope, use_isolation_scope #3522

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Use POTel use_scope, use_isolation_scope #3522

merged 3 commits into from
Sep 12, 2024

Conversation

sentrivana
Copy link
Contributor

Replace usages of use_scope, use_isolation_scope with the POTel-friendly variant.

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

❌ 3419 Tests Failed:

Tests completed Failed Passed Skipped
16630 3419 13211 1445
View the top 3 failed tests by shortest run time 
tests.integrations.celery.test_celery test_baggage_propagation
Stack Traces | 0s run time 
No failure message available

tests.integrations.celery.test_celery test_producer_span_data[redis]
Stack Traces | 0s run time 
No failure message available

tests.integrations.celery.test_celery test_transaction_events[<lambda>1-error]
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

sl0thentr0py
sl0thentr0py requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you expose these to top level api and use them here because we'll need to make a top level switch eventually on the 2 scope implementations

sl0thentr0py
sl0thentr0py approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci

@sentrivana sentrivana merged commit a4bc9de into potel-base Sep 12, 2024
10 of 108 checks passed
@sentrivana sentrivana deleted the ivana/potel/use-potelscope branch September 12, 2024 06:30
@sentrivana sentrivana mentioned this pull request Sep 12, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @sl0thentr0py